Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/9003#issuecomment-149788583
@mengxr Addressed all comments and rearranged the class inheritances for
case classes. I made another abstract class `SecondMoment` which all `Variance`
classes inherit from - I think this will make the addition of the `StdDev`
classes very simple.
Items still to be addressed:
* I have not implemented using the `AggregateFunction1` interface since I
believe it will be removed. Right now, I have added placeholders that just copy
the code for `Average` so that the current code will compile. I'm not sure if I
need to implement this or if we can just wait until the `AggregateFunction1`
interface is removed.
* I need to add tolerancing to the `checkAnswer` function in SQL test suite
because aggregate stats do not result in exact answers for the test data (e.g.
0.0 != 5e-17). I will work on this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
