Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9203#discussion_r42686721
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -618,6 +618,25 @@ public void writeTo(ByteBuffer buffer) {
buffer.position(pos + sizeInBytes);
}
+ /**
+ * Write the bytes of var-length field into ByteBuffer
+ */
+ public void writeFieldTo(int ordinal, ByteBuffer buffer) {
+ final long offsetAndSize = getLong(ordinal);
+ final int offset = (int) (offsetAndSize >> 32);
+ final int size = (int) (offsetAndSize & ((1L << 32) - 1));
--- End diff --
can we create a constant for (1L << 32) - 1?
We have a lot of them now in this file. LOWER_32_BIT_MASK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
