Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9201#discussion_r42696318
  
    --- Diff: conf/spark-env.sh.template ---
    @@ -39,7 +39,7 @@
     # - SPARK_EXECUTOR_INSTANCES, Number of workers to start (Default: 2)
     # - SPARK_EXECUTOR_CORES, Number of cores for the workers (Default: 1).
     # - SPARK_EXECUTOR_MEMORY, Memory per Worker (e.g. 1000M, 2G) (Default: 1G)
    -# - SPARK_DRIVER_MEMORY, Memory for Master (e.g. 1000M, 2G) (Default: 1G)
    +# - SPARK_DRIVER_MEMORY, Memory for Driver (e.g. 1000M, 2G) (Default: 1G)
    --- End diff --
    
    This seems fine. It occurs to me that the lines above refer to 'workers' 
which seems odd since this is clearly about executors, and YARN mode. Maybe 
those should change too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to