Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9229#discussion_r42793556
--- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
@@ -32,20 +32,33 @@ import org.apache.spark.util.random.XORShiftRandom
*
*/
private[ann] trait Layer extends Serializable {
+
+ /**
+ * Number of weights that is used to allocate memory for the weights
vector
+ */
+ val weightSize: Int
+
+ /**
+ * Returns the output size given the input size (not counting the stack
size).
+ * Output size is used to allocate memory for the output.
+ * @param inputSize input size
+ * @return output size
+ */
+ def outputSize(inputSize: Int): Int
+
/**
* Returns the instance of the layer based on weights provided
* @param weights vector with layer weights
- * @param position position of weights in the vector
* @return the layer model
*/
- def getInstance(weights: Vector, position: Int): LayerModel
-
+ def instance(weights: BDV[Double]): LayerModel
--- End diff --
`Layer` is really implementing the Factory pattern for `LayerModel`. Should
we consider renaming it to use the proper name?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
