Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9216#issuecomment-150395202 My code change expose a new defect: Both rollup and cube are not working correctly no matter whether the build include my changes or not. Without my changes, the outputs of rollup query are [3,2,-1] [3,null,null] [6,4,-2] [6,null,null] [null,null,null] However, the expected results should be like [3,2,-1] [3,null,-1] [6,4,-2] [6,null,-2] [null,null,-3] I need more time to find the root cause why rollup and cube do not work. The current test cases in HiveDataFrameAnalyticsSuite hide the errors because both the results of both SQL and DataFrame are wrong, although the results are the same. Thanks, Xiao Li
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org