Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/8093#discussion_r42916732 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -367,9 +367,15 @@ private[spark] object JsonProtocol { ("Job ID" -> taskCommitDenied.jobID) ~ ("Partition ID" -> taskCommitDenied.partitionID) ~ ("Attempt Number" -> taskCommitDenied.attemptNumber) - case ExecutorLostFailure(executorId, isNormalExit) => - ("Executor ID" -> executorId) ~ - ("Normal Exit" -> isNormalExit) + case ExecutorLostFailure(executorId, isNormalExit, reason) => + if (reason.isDefined) { + ("Executor ID" -> executorId) ~ + ("Normal Exit" -> isNormalExit) ~ + ("Loss Reason" -> reason.get.toString) --- End diff -- Nevermind, that method is for reading. (Man I really dislike this class.) Anyway, you could probably get away with `reason.map(JString(_)).getOrElse(JNothing)` as is done in other places. Bonus brownie points for writing a helper method for that.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org