Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/9232#discussion_r42939248 --- Diff: yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtilSuite.scala --- @@ -245,4 +247,28 @@ class YarnSparkHadoopUtilSuite extends SparkFunSuite with Matchers with Logging System.clearProperty("SPARK_YARN_MODE") } } + + test("Obtain tokens For HiveMetastore") { + val hadoopConf = new Configuration() + hadoopConf.set("hive.metastore.kerberos.principal", "bob") + // thrift picks up on port 0 and bails out, without trying to talk to endpoint + hadoopConf.set("hive.metastore.uris", "http://localhost:0") + val util = new YarnSparkHadoopUtil + val e = intercept[InvocationTargetException] { + val token = util.obtainTokenForHiveMetastoreInner(hadoopConf, "alice") + fail(s"Expected an exception, got the token $token") + } + val inner = e.getCause + if (inner == null) { + fail("No inner cause", e) + } + if (!inner.isInstanceOf[HiveException]) { + fail(s"Not a hive exception", inner) + } + // expect exception trapping code to unwind this hive-side exception + intercept[HiveException] { + val token = util.obtainTokenForHiveMetastore(hadoopConf) + fail(s"Expected an exception, got the token $token") --- End diff -- Again, that's what `intercept` is for.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org