Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9243#issuecomment-150939010
The motivation here is not just memory, but (secondarily) avoiding the
outstanding Kryo serialization problem and simplifying the build.
The explanations here all make sense, but the question is, does this change
reduce memory consumption or not? The assertion is that it does by about 20%
and I'm not clear if we're arguing that doesn't make sense or not. I am not
sure I'd expect the set of non-empty blocks to be sparse? so maybe it does.
If it doesn't obviously change memory consumption either way, then it's
still a win.
I still don't get why the test is timing out though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
