Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1229#discussion_r14252256
  
    --- Diff: 
core/src/main/scala/org/apache/spark/util/random/RandomSampler.scala ---
    @@ -54,17 +54,17 @@ trait RandomSampler[T, U] extends Pseudorandom with 
Cloneable with Serializable
      */
     @DeveloperApi
     class BernoulliSampler[T](lb: Double, ub: Double, complement: Boolean = 
false)
    --- End diff --
    
    Could dropping this implicit break source and binary compatiblity? I think 
we'd like to avoid asking people to make code changes to upgrade to a bug-fix 
release, even if the API's are marked as developer. Can you just leave the 
existing argument and just ignore it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to