Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/9232#issuecomment-151173854
-Updated patch pulls the `val token=` and `fail` code from the tests. It
also pulls out the logic for deciding what to do with exceptions into its own
class, which has two benefits.
1. The logic can be tested directly, going through all the possible clauses
of the match statement, and any conditions inside them.
1. The hbase introspection code can be reworked to use the same method.
This would guarantee one single implementation of logging & rethrow policy
across the two (and any future) token acquisition clauses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
