Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9288#discussion_r43089305
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -615,7 +615,11 @@ private[spark] class ExecutorAllocationManager(
val taskIndex = taskEnd.taskInfo.index
val stageId = taskEnd.stageId
allocationManager.synchronized {
- numRunningTasks -= 1
+ if (numRunningTasks > 0) {
--- End diff --
Hm, this seems like a band-aid though. Is this because the task-end event
happens in the wrong order with the job end event? can we catch and guard for
that case more directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
