Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9238#discussion_r43100632
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala
---
@@ -73,4 +73,11 @@ private[history] abstract class
ApplicationHistoryProvider {
@throws(classOf[SparkException])
def writeEventLogs(appId: String, attemptId: Option[String], zipStream:
ZipOutputStream): Unit
+ /**
+ * Read in the event logs from zip input stream provided and replayed by
history provider.
+ * @param zipStream Input zip stream.
+ * @throws SparkException if there's any exception read in the zip
stream.
+ */
+ @throws(classOf[SparkException])
+ def readEventLogs(zipStream: ZipInputStream): Unit
--- End diff --
Rather than make this abstract, can you add a stub method which just goes
`throw new SparkException("Unsupported Feature")`. That way any existing
history provider will still load
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
