Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8587#discussion_r43162228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
@@ -747,6 +747,19 @@ case class LastFunction(
}
}
+/**
+ * Calculate Pearson Correlation Coefficient for the given columns.
+ * Only support AggregateExpression2.
+ *
+ */
+case class Corr(
+ left: Expression,
+ right: Expression) extends BinaryExpression with AggregateExpression {
+ override def nullable: Boolean = false
+ override def dataType: DoubleType.type = DoubleType
+ override def toString: String = s"CORRELATION($left, $right)"
+}
--- End diff --
What will be the error message if we call this function when
`spark.sql.useAggregate2=false`? It will be good to provide a meaning error
message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
