Github user rick-ibm commented on the pull request:
https://github.com/apache/spark/pull/9202#issuecomment-151608061
Thanks for the advice about how to improve this patch, Sean. Hopefully, my
last commit addresses your concerns. I have made the following changes:
1) Eliminated the Java code (SqlIdentifierUtil) and replaced it with a
Scala class (SqlIdUtil).
2) Revamped the id parsing to use a Scala regular expression.
3) Introduced a case class (TableId) to represent a 3-part table identfier.
This replaces the ordered triple which performed the same service in the
previous rev of the patch.
Thanks,
-Rick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
