Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1151#discussion_r14277596
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
    @@ -614,6 +614,8 @@ private[hive] object HiveQl {
           queries.reduceLeft(Union)
     
         case Token("TOK_UNION", left :: right :: Nil) => 
Union(nodeToPlan(left), nodeToPlan(right))
    +    
    +    case Token("TOK_EXCEPT", left :: right :: Nil) => 
Subtract(nodeToPlan(left), nodeToPlan(right)) 
    --- End diff --
    
    Does this compile? Isn't the logical node called `Except`?  I think maybe 
you need to set `SPARK_HIVE=true` so that Hive code is also compiled.
    
    Also, it would be good to add a test case for the hive branch of the code 
as well.  Perhaps in `HiveQuerySuite`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to