Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9182#discussion_r43253907
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -51,6 +51,38 @@ private[spark] abstract class YarnSchedulerBackend(
     
       private implicit val askTimeout = RpcUtils.askRpcTimeout(sc.conf)
     
    +  /** Application ID. Must be set by a subclass before starting the 
service */
    +  private var appId: ApplicationId = null
    +
    +  /** Attempt ID. This is unset for client-side schedulers */
    --- End diff --
    
    nit: "client mode schedulers" is more in line with how the rest of code 
refers to things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to