Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9362#discussion_r43456658
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -712,6 +722,9 @@ class SparseVector @Since("1.0.0") (
}
}
+ @Since("1.6.0")
+ private[spark] def foreach(f: (Double) => Unit) = { indices.foreach { i:
Int => f(values(i)) } }
--- End diff --
yah, I think this implementation was the result of a miscommunication, I
believe the intended purpose is to provide something matching the normal
foreach function (why the PR was changed back to a WIP)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
