Github user rick-ibm commented on the pull request:
https://github.com/apache/spark/pull/9345#issuecomment-152355615
Hi Christian,
The patch looks good to me. I would recommend putting the restoration of
the logging state inside a finally block. I don't know if that will change the
behavior of this test, but it seems like good future-proofing in case someone
else wants to copy your approach later on.
Thanks,
-Rick
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
