Github user Lewuathe commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43474383
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -112,8 +139,13 @@ object LinearDataGenerator {
x.foreach { v =>
var i = 0
val len = v.length
+ val sparceRnd = new Random(seed)
--- End diff --
If we use same random generator for both creating features and choice which
columns to zero, x is different from current ones. This cause unit test
failures. Can we change the assertion tolerance or target written in
`LinearRegressionSuite`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
