Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9344#issuecomment-152802197
The current approach of having separate methods named `*OnHeap` and
`*OffHeap` seems error-prone in the long run. Instead, it might be better to
create an enumeration for tracking which category memory belongs to, then to
have methods which take an extra parameter to specify whether the memory is on-
or off-heap. We could use a boolean parameter but I'd rather use explicit
enumerations to make the types clearer in Java code where we can't use the
Scala-style naming of arguments at method call sites.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
