Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9399#discussion_r43590334
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -295,18 +309,20 @@ private[sql] object DataSourceStrategy extends
Strategy with Logging {
val requestedColumns =
projects.asInstanceOf[Seq[Attribute]] // Safe due to if above.
.map(relation.attributeMap) // Match original case of
attributes.
+ .filterNot(handledSet.contains)
val scan = execution.PhysicalRDD.createFromDataSource(
projects.map(_.toAttribute),
- scanBuilder(requestedColumns, pushedFilters),
+ scanBuilder(requestedColumns, candidatePredicates, pushedFilters),
--- End diff --
I mean `pushedFilters` contains all filters in the `Filter` form that can
be handled by the data source, why not change `candidatePredicates` to catalyst
filters that can be handled by the data source.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
