Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9399#discussion_r43594749
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/sources/ParquetHadoopFsRelationSuite.scala
 ---
    @@ -145,14 +145,16 @@ class ParquetHadoopFsRelationSuite extends 
HadoopFsRelationTest {
     
       test("SPARK-10334 Projections and filters should be kept in physical 
plan") {
         withTempPath { dir =>
    -      val path = dir.getCanonicalPath
    +      withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "false") {
    --- End diff --
    
    Oh, actually I implemented `ParquetRelation.unhandledFilters` locally to 
help verifying this PR and then reverted it. This change is needed to because 
the filter in the query below will be pushed down and removed from the physical 
query plan after the aforementioned change. This change should also be reverted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to