Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9270#discussion_r43658099
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ScalaUDF.scala
---
@@ -959,6 +963,122 @@ case class ScalaUDF(
}
}
+ // Generate codes used to convert the arguments to Scala type for
user-defined funtions
+ private[this] def genCodeForConverter(ctx: CodeGenContext, index: Int):
String = {
+ val converterClassName = classOf[Any => Any].getName
+ val typeConvertersClassName = CatalystTypeConverters.getClass.getName
+ ".MODULE$"
+ val expressionClassName = classOf[Expression].getName
+ val scalaUDFClassName = classOf[ScalaUDF].getName
+
+ val converterTerm = ctx.freshName("converter" + index.toString)
--- End diff --
Why `index` here? All freshName will be unique.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
