Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9214#discussion_r43664703
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java
---
@@ -121,13 +125,22 @@ public BypassMergeSortShuffleWriter(
}
@Override
- public void write(Iterator<Product2<K, V>> records) throws IOException {
+ public Seq<Tuple2<File, File>> write(Iterator<Product2<K, V>> records)
throws IOException {
--- End diff --
Could you add a javadoc explaining what the return value is? It's
particularly cryptic because it's uses tuples; maybe it would be better to
create a helper type where the fields have proper names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
