Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9413#discussion_r43685972 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -471,6 +484,59 @@ class LinearRegressionSummary private[regression] ( predictions.select(t(col(predictionCol), col(labelCol)).as("residuals")) } + lazy val numInstances: Long = predictions.count() + + lazy val dfe = if (model.getFitIntercept) { --- End diff -- Keep this one private, or a more descriptive name? We need explicit types for public/private members.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org