Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8840#discussion_r43775309
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
---
@@ -58,14 +58,46 @@ class ParquetPartitionDiscoverySuite extends QueryTest
with ParquetTest with Sha
check(defaultPartitionName, Literal.create(null, NullType))
}
+ test("parse invalid partitioned directories") {
+ // Invalid
+ var paths = Seq(
+ "hdfs://host:9000/invalidPath",
+ "hdfs://host:9000/path/a=10/b=20",
+ "hdfs://host:9000/path/a=10.5/b=hello")
+
+ var exception = intercept[AssertionError] {
+ parsePartitions(paths.map(new Path(_)), defaultPartitionName, true)
+ }
+ assert(exception.getMessage().contains("Conflicting directory
structures detected"))
+
+ // Valid
+ paths = Seq(
+ "hdfs://host:9000/path/_temporary",
+ "hdfs://host:9000/path/a=10/b=20",
+ "hdfs://host:9000/path/_temporary/path")
+
+ parsePartitions(paths.map(new Path(_)), defaultPartitionName, true)
+
+ // Invalid
+ paths = Seq(
+ "hdfs://host:9000/path/_temporary",
+ "hdfs://host:9000/path/a=10/b=20",
+ "hdfs://host:9000/path/path1")
+
+ exception = intercept[AssertionError] {
+ parsePartitions(paths.map(new Path(_)), defaultPartitionName, true)
+ }
+ assert(exception.getMessage().contains("Conflicting directory
structures detected"))
+ }
--- End diff --
Which case is for the one I mentioned in the jira?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
