Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8923#issuecomment-153434627
I see, so this comes from a "diamond" dependency. I'm not seeing that in
your "after" image though -- am I just missing it with too many criss-crossing
lines? I'm wondering if there is another bug w/ either the listener events or
the visualization.
I'm actually wondering if there is any point in building up the `parents`
structure at all -- you could also just directly add to `shuffleToMapStage`
inside `getAncestorShuffleDependencies`. eg. just inline this
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L286
to
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L417.
That is the only use of `getAncestorShuffleDependencies`, what do you think
aboutjust renaming it to `registerAncestorShuffleDependencies` and having it do
both? I think it would actually be easier to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
