Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r43809466
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -213,12 +225,13 @@ private[streaming] class ReceivedBlockTracker(
}
/** Write an update to the tracker to the write ahead log */
- private def writeToLog(record: ReceivedBlockTrackerLogEvent) {
+ private[streaming] def writeToLog(record: ReceivedBlockTrackerLogEvent):
Boolean = {
if (isWriteAheadLogEnabled) {
- logDebug(s"Writing to log $record")
- writeAheadLogOption.foreach { logManager =>
- logManager.write(ByteBuffer.wrap(Utils.serialize(record)),
clock.getTimeMillis())
- }
+ logTrace(s"Writing record: $record")
+
writeAheadLogOption.get.write(ByteBuffer.wrap(Utils.serialize(record)),
--- End diff --
Can you break this into two lines, with the condition being on a separate
line. Had look twice to figure out that this is both a call and a condition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
