Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/9419#discussion_r43833223
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -232,7 +232,7 @@ class Analyzer(
// substitute the group by expressions.
val newGroupByExprs = groupByExprPairs.map(_._2)
--- End diff --
Take this for example:
```sql
select sum(a-b) as ab from mytable group by b with rollup;
```
I think we probably need to add extra column(s) for the output of `Expand`,
(e.g. `(a-b)` in this case). Will that be more simple for this fixing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
