Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r43961907
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceivedBlockTracker.scala
---
@@ -157,9 +166,12 @@ private[streaming] class ReceivedBlockTracker(
require(cleanupThreshTime.milliseconds < clock.getTimeMillis())
val timesToCleanup = timeToAllocatedBlocks.keys.filter { _ <
cleanupThreshTime }.toSeq
logInfo("Deleting batches " + timesToCleanup)
- writeToLog(BatchCleanupEvent(timesToCleanup))
- timeToAllocatedBlocks --= timesToCleanup
- writeAheadLogOption.foreach(_.clean(cleanupThreshTime.milliseconds,
waitForCompletion))
+ if (writeToLog(BatchCleanupEvent(timesToCleanup))) {
+ timeToAllocatedBlocks --= timesToCleanup
+ writeAheadLogOption.foreach(_.clean(cleanupThreshTime.milliseconds,
waitForCompletion))
--- End diff --
This is not actually new, but I think we should clean first and then remove
the times from the `timeToAllocatedBlocks` map. Otherwise, failed cleanups can
lead to the logs never getting cleaned up at all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
