Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9421#discussion_r44065382
--- Diff:
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala
---
@@ -135,18 +105,17 @@ private[kinesis] class KinesisRecordProcessor[T](
*/
override def shutdown(checkpointer: IRecordProcessorCheckpointer,
reason: ShutdownReason) {
logInfo(s"Shutdown: Shutting down workerId $workerId with reason
$reason")
- reason match {
+ // We want to return a checkpointer based on the shutdown cause. If we
want to terminate,
--- End diff --
I dont get this. Dont we always want remove the checkpointer when
shutdown() is called irrespective of the reason of shutdown?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
