Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9358#discussion_r44097663
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -148,18 +152,37 @@ class Dataset[T] private(
def transform[U](t: Dataset[T] => Dataset[U]): Dataset[U] = t(this)
/**
+ * (Scala-specific)
* Returns a new [[Dataset]] that only contains elements where `func`
returns `true`.
* @since 1.6.0
*/
def filter(func: T => Boolean): Dataset[T] =
mapPartitions(_.filter(func))
/**
+ * (Java-specific)
+ * Returns a new [[Dataset]] that only contains elements where `func`
returns `true`.
+ * @since 1.6.0
+ */
+ def filter(func: JFunction[T, java.lang.Boolean]): Dataset[T] =
--- End diff --
After talking with @rxin we should probably create `FilterFunction` both
because here we can avoid boxing and also because this might be less confusing
to java users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
