Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/9480#discussion_r44108481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -151,6 +164,30 @@ abstract class Expression extends TreeNode[Expression]
{
}
/**
+ * Returns the hash for this expression. Expressions that compute the
same result, even if
+ * they differ cosmetically should return the same hash.
+ */
+ def semanticHash() : Int = {
--- End diff --
And there is more discussion on the `semanticEquals` can be found at #6587,
even, I don't think we need the `semanticEquals` if we changed the
implementation of `AttributeReference.equals`, as it does make lots of code
complicated like this one, by using the `semanticEquals`, other than `equals`
or `==`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
