Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1272#discussion_r14391324
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -64,20 +65,21 @@ trait SQLConf {
}
def get(key: String): String = {
- if (!settings.containsKey(key)) {
- throw new NoSuchElementException(key)
- }
settings.get(key)
}
def get(key: String, defaultValue: String): String = {
- if (!settings.containsKey(key)) defaultValue else settings.get(key)
+ settings.synchronized {
+ if (!settings.containsKey(key)) defaultValue else settings.get(key)
--- End diff --
Let's use the ConcurrentHashMap-safe paradigm of
```scala
Option(settings.get(key)).getOrElse(defaultValue)
```
Note that ConcurrentHashMap does not allow null values, so this is safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
