GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/9556
[SPARK-9830] [SQL] Remove AggregateExpression1 and Aggregate Operator used to evaluate AggregateExpression1s https://issues.apache.org/jira/browse/SPARK-9830 This PR removes `AggregateExpression1`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/yhuai/spark removeAgg1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/9556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9556 ---- commit 96e3e369759067c863ae6e0065eb0b1804dbfb5d Author: Yin Huai <yh...@databricks.com> Date: 2015-11-06T23:35:20Z Remove agg1 from the planner. commit 9921733491930581aefe8f65bf9d5d8b995f99e5 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T06:21:27Z Add needed constructors. commit f126520283f127b610f6255275de98e5c4ce1d37 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T06:26:23Z Delete old agg functions. commit 5a177ec92726274abe3c5acec01e29d7b0f688d4 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T06:40:58Z Update function registry and DataFrame functions. commit f5a389faf073dbcb5bc13fda81f993a63498e448 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T06:53:31Z Update analyzer. commit 3d06cfd6c471fb5976b9124083b6d8b2667b411a Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T06:56:05Z Update optimizer. commit 7e77628e57acaba0ed3c24645fe69470e487c135 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T07:05:31Z Update parsers, check analysis, and hive type coercion. commit 55841a551f9ff20e21c1d1a6afc0a6b39dd15d9e Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T19:45:02Z Update catalyst dsl. commit d2ca2902a60a0ea3796d1737a7c01fd863d1781c Author: Yin Huai <yh...@databricks.com> Date: 2015-11-07T19:49:11Z Update HiveTypeCoercion commit aa8daa99398392b6f3ba5c0e18576e7f0b99553b Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T00:38:28Z Update logical operators. commit 10630e1a230e5fde9671fe0bac07c8c1af74c087 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T00:41:41Z Merge remote-tracking branch 'upstream/master' into removeAgg1 commit e8d39d146b2a629f640cfd45d54f97564228a772 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T00:56:52Z Remove the mapping from old agg functions to new agg functions. commit a3df1fd9c978a3e2a4fdbec04ee0827066eb1e7a Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T01:01:30Z Remove old agg operator. commit 5ed4970382ab09d4e7f8a606c1fbde41c8cfe348 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T02:41:33Z Throw exception when we have count distinct. Once https://github.com/apache/spark/pull/9409 is in, we will remove this limitation. commit 881afe8637acfa74044947563a08d80a8150fd91 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T05:11:03Z Update tests. commit 24512337ad035de47d6402ee4fb50206575973d5 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-08T05:12:50Z Style. commit 1ef0b92ac4472d0c4e9c662a8b08eb4494712b3a Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T00:03:06Z Check analysis. commit 35dfe9340e7f62fa3c59636a0024e4d2caf5892d Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T01:07:45Z Fix AggregateQuerySuite. commit 6d2919554b53176c1bdf4f2837404e044eba9876 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T02:47:35Z Merge remote-tracking branch 'upstream/master' into removeAgg1 Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Utils.scala commit 383511048cbadb37a392f7cde820a83bfd64bf37 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T03:39:49Z Fix test. commit c88c97d49b83e6fc4cc9b0d1aa27462d6fe67417 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T04:18:49Z Since an agg function's children can be unresolved (when we use them in DF's API), making all fields that may use children lazy vals. commit c6c6c094dd2efde9778bd1bff5f4cf3c897db9f1 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T04:41:36Z Fix tests. commit b73156ad39f90ff52ad3091da1c274ae565da46f Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T04:42:40Z style commit cb3f4d3f6486b0aa1b668ee901cde353e829b7f5 Author: Yin Huai <yh...@databricks.com> Date: 2015-11-09T04:45:31Z Renaming: AggregateExpression2 => AggregateExpression AggregateFunction2 => AggregateFunction ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org