Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/9143#discussion_r44243570
--- Diff:
streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala
---
@@ -58,49 +71,127 @@ class WriteAheadLogSuite extends SparkFunSuite with
BeforeAndAfter {
Utils.deleteRecursively(tempDir)
}
- test("WriteAheadLogUtils - log selection and creation") {
- val logDir = Utils.createTempDir().getAbsolutePath()
+ test(testPrefix + "read all logs") {
+ // Write data manually for testing reading through WriteAheadLog
+ val writtenData = (1 to 10).map { i =>
+ val data = generateRandomData()
+ val file = testDir + s"/log-$i-$i"
+ writeDataManually(data, file)
--- End diff --
Actually, we dont guarantee cross release compatibility. So achieving that
is less important. Its more important to actually test the base case with
batching, write batched data and read batched data. Similar to the
FileBasedWALSuite where this unit test tests the reader's ability to read
manually/directly written data, i was expecting this same unit test for
BatchedWALSuite to test reading of batched data by reading directly generated
batched data.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
