Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155054384
Made a quick pass. I think the PR is in good shape. I do have a few
aditional questions/remarks:
* Maybe should add some documentation to ```DeclarativeAggregate``` to
explain why developers have to use lazy vals for all expressions involving the
child expression(s).
* ```MultipleDistinctRewriter``` is in a 'funny' file/location. Shouldn't
we move it to the analyzer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
