Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9568#discussion_r44273796
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/udaf.scala ---
    @@ -129,6 +129,13 @@ abstract class UserDefinedAggregateFunction extends 
Serializable {
             isDistinct = true)
         Column(aggregateExpression)
       }
    +
    +  /**
    +    * The name of the UDAF. This is currently the simple name of class. 
This can create an
    +    * [[java.lang.InternalError]] if the UDAF class was created in the 
REPL; override this method
    +    * in these cases.
    +    */
    +  def name: String = getClass.getSimpleName
    --- End diff --
    
    I am not catching a ```java.lang.InternalError``` here, because I think 
these shouldn't be caught at all (the error could have different cause). We 
enable the use to redefine the name to work arround this problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to