Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9413#discussion_r44308271
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -474,6 +487,75 @@ class LinearRegressionSummary private[regression] (
         predictions.select(t(col(predictionCol), 
col(labelCol)).as("residuals"))
       }
     
    +  /** Number of instances in DataFrame predictions */
    +  lazy val numInstances: Long = predictions.count()
    +
    +  /** Degrees of freedom */
    +  private val degreesOfFreedom: Long = if (model.getFitIntercept) {
    +    numInstances - model.coefficients.size - 1
    +  } else {
    +    numInstances - model.coefficients.size
    +  }
    +
    +  /**
    +   * The weighted residuals, the usual residuals rescaled by
    +   * the square root of the instance weights.
    +   */
    +  lazy val devianceResiduals: Array[Double] = {
    --- End diff --
    
    Sounds good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to