Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9428#discussion_r44322179 --- Diff: core/src/main/scala/org/apache/spark/util/CheckpointingIterator.scala --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.util + +import java.io.IOException +import java.util.concurrent.ConcurrentHashMap + +import scala.reflect.ClassTag +import scala.util.control.NonFatal + +import org.apache.hadoop.fs.{FileSystem, Path} + +import org.apache.spark._ +import org.apache.spark.broadcast.Broadcast +import org.apache.spark.rdd.{RDD, ReliableCheckpointRDD} +import org.apache.spark.storage.RDDBlockId + +/** + * Wrapper around an iterator which writes checkpoint data to HDFS while running action on + * an RDD. + * + * @param id the unique id for a partition of an RDD + * @param values the data to be checkpointed + * @param fs the FileSystem to use + * @param tempOutputPath the temp path to write the checkpoint data + * @param finalOutputPath the final path to move the temp file to when finishing checkpointing + * @param context the task context + * @param blockSize the block size for writing the checkpoint data + */ +private[spark] class CheckpointingIterator[T: ClassTag]( + id: RDDBlockId, + values: Iterator[T], + fs: FileSystem, + tempOutputPath: Path, + finalOutputPath: Path, + context: TaskContext, + blockSize: Int) extends Iterator[T] with Logging { + + private[this] var completed = false --- End diff -- does this need to be volatile?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org