Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9556#issuecomment-155180027 I think one follow-up work is to add tests in `ExpressionTypeCheckingSuite` to make sure those newly added agg functions (e.g. corr and variance) throw the right exception when the input data types do not match the expected types.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org