Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9546#discussion_r44361026
  
    --- Diff: 
core/src/main/scala/org/apache/spark/util/AsynchronousListenerBus.scala ---
    @@ -66,16 +66,13 @@ private[spark] abstract class AsynchronousListenerBus[L 
<: AnyRef, E](name: Stri
             self.synchronized {
               processingEvent = true
             }
    +        if (stopped.get()) {
    +          // Get out of the while loop and shutdown the daemon thread
    +          return
    +        }
    --- End diff --
    
    can you move this into the `try`? If `stopped.get` throws an exception we 
still want to set `processingEvent` to false


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to