Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/9582#issuecomment-155274214
LGTM.
I just want to discuss a BKM here for all cases of such kind. That is we
want to add in SparkR a function which also an existing S3 geneirc function
defined in R Base package. There are two ways for use to add such function in
SparkR:
1. Define an S4 generic function, which has compatible signature with the
existing S3 generic function in Base package. Then use setMethod() to define
the our own method for SparkR;
2. No need to define an S4 generic function. Just define a new S3 method
for the existing S3 generic function. For example, for this case, we could:
summary.DataFrame <- ...
I am not sure which is better. I think we can have a discussion and find a
preferred style. We can consistently use that style later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
