GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/1294

    Don't throw TreeNodeException in `execution.ExplainCommand`

    This is a fix for the problem revealed by PR #1265.
    
    Currently `HiveComparisonSuite` ignores output of `ExplainCommand` since 
Catalyst query plan is quite different from Hive query plan. But exceptions 
throw from `CheckResolution` still breaks test cases. This PR catches any 
`TreeNodeException` and reports it as part of the query explanation.
    
    After merging this PR, PR #1265 can also be merged safely.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark safe-explain

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1294
    
----
commit 4318911f878987eae062e19f97f63a6fd52fa35f
Author: Cheng Lian <lian.cs....@gmail.com>
Date:   2014-07-03T20:42:54Z

    Don't throw TreeNodeException in `execution.ExplainCommand`
    
    This is a fix for the problem revealed by [PR 
#1265](https://github.com/apache/spark/pull/1265)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to