Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9568#discussion_r44487589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/udaf.scala ---
@@ -129,6 +129,13 @@ abstract class UserDefinedAggregateFunction extends
Serializable {
isDistinct = true)
Column(aggregateExpression)
}
+
+ /**
+ * The name of the UDAF. This is currently the simple name of class.
This can create an
+ * [[java.lang.InternalError]] if the UDAF class was created in the
REPL; override this method
+ * in these cases.
+ */
+ def name: String = getClass.getSimpleName
--- End diff --
I am wondering if we can catch the error and re-throw it with a more
informative error message? In our error message, we can let the user know
he/she needs to override `def name` to workaround that Scala issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
