Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/9060#issuecomment-155718158
@HyukjinKwon Oh yeah, sorry. Finally got sometime to clean my review queue
:)
I wonder is there an easy way to add a test case for this? At first I
thought `WriterVersion` corresponds to the the `version` field of the Thrift
struct `FileMetaData` described in [parquet-format] [1], but it's not. I only
found that when `WriterVersion` is set to v2, the Thrift field
`PageHeader.type` is set to `DATA_PAGE_V2`.
[1]: https://github.com/apache/parquet-format#metadata
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
