Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/9405#discussion_r44523864
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRelation.scala
---
@@ -208,7 +208,15 @@ private[sql] class ParquetRelation(
// Parquet data source always uses Catalyst internal representations.
override val needConversion: Boolean = false
- override def sizeInBytes: Long =
metadataCache.dataStatuses.map(_.getLen).sum
+ override def sizeInBytes: Long =
+ if (shouldMergeSchemas && mergeRespectSummaries) {
+ // If we are going to merge schema and this relation is configured to
+ // respect summaries (i.e., skip part-files), we will assume that
the size of
+ // this relation is large and can't be broadcasted.
--- End diff --
Right. But compared to set a smaller `sizeInBytes`, a larger one seems
better as wrongly broadcasting large relation should be worse?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
