Github user reggert commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r44564647
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,31 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
BeforeAndAfterAll with Tim
Await.result(f, Duration(20, "milliseconds"))
}
}
+
+ private def testAsyncAction[R](action : RDD[Int] => FutureAction[R]) :
Unit = {
+ val executorInvoked = Promise[Unit]
+ val fakeExecutionContext = new ExecutionContext {
+ override def execute(runnable: Runnable): Unit = {
+ executorInvoked.success(())
+ }
+ override def reportFailure(t: Throwable): Unit = ()
+ }
+ /*
+ We sleep here so that we get to the assertion before the job
completes.
+ I wish there were a cleaner way to do this, but trying to use any
sort of synchronization
+ with this fails due to task serialization.
+ */
+ val rdd = sc.parallelize(1 to 100, 4).mapPartitions(itr =>
{Thread.sleep(1000L); itr})
--- End diff --
I just copied the style of the test appears immediately above this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
