Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7888#discussion_r44579027
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -410,8 +410,9 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
        * Request that the cluster manager kill the specified executors.
        * @return whether the kill request is acknowledged.
        */
    -  final override def killExecutors(executorIds: Seq[String]): Boolean = 
synchronized {
    -    killExecutors(executorIds, replace = false)
    +  final override def killExecutors(
    +      executorIds: Seq[String]): Boolean = synchronized {
    --- End diff --
    
    this fits on the previous line comfortably I think. Can you put it back?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to