Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/1272#discussion_r14545788
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -64,20 +64,17 @@ trait SQLConf {
}
def get(key: String): String = {
- if (!settings.containsKey(key)) {
- throw new NoSuchElementException(key)
- }
- settings.get(key)
+ Option(settings.get(key)).orElse(throw new NoSuchElementException(key))
--- End diff --
This follows code style from `BlockManager`:
def getLocalFromDisk(blockId: BlockId, serializer: Serializer):
Option[Iterator[Any]] = {
diskStore.getValues(blockId, serializer).orElse(
sys.error("Block " + blockId + " not found on disk, though it
should be"))
}
Anyway `throw` expression return `Nothing`, which can work with both
`getOrElse` and `orElse`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
